From 0b1c27819e2d99aabdac31820e7a73741a7f8c0f Mon Sep 17 00:00:00 2001
From: Rune Harlyk <rune@harlyk.dk>
Date: Thu, 14 Nov 2024 11:27:01 +0100
Subject: [PATCH] =?UTF-8?q?=F0=9F=9A=92=20Updates=20firmware=20download=20?=
 =?UTF-8?q?service=20interface?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 esp32/lib/ESP32-sveltekit/firmware_download_service.cpp | 7 ++++---
 esp32/lib/ESP32-sveltekit/firmware_download_service.h   | 2 +-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/esp32/lib/ESP32-sveltekit/firmware_download_service.cpp b/esp32/lib/ESP32-sveltekit/firmware_download_service.cpp
index 495af96..7336ab8 100644
--- a/esp32/lib/ESP32-sveltekit/firmware_download_service.cpp
+++ b/esp32/lib/ESP32-sveltekit/firmware_download_service.cpp
@@ -91,7 +91,7 @@ void updateTask(void *param) {
 
 DownloadFirmwareService::DownloadFirmwareService() {}
 
-esp_err_t DownloadFirmwareService::downloadUpdate(PsychicRequest *request, JsonVariant &json) {
+esp_err_t DownloadFirmwareService::handleDownloadUpdate(PsychicRequest *request, JsonVariant &json) {
     if (!json.is<JsonObject>()) {
         return request->reply(400);
     }
@@ -108,8 +108,9 @@ esp_err_t DownloadFirmwareService::downloadUpdate(PsychicRequest *request, JsonV
 
     socket.emit(EVENT_DOWNLOAD_OTA, output.c_str());
 
-    if (g_taskManager.createTask(&updateTask, "Firmware download", OTA_TASK_STACK_SIZE, &downloadURL,
-                                 (configMAX_PRIORITIES - 1), NULL, 1) != pdPASS) {
+    const BaseType_t taskResult = g_taskManager.createTask(&updateTask, "Firmware download", OTA_TASK_STACK_SIZE,
+                                                           &downloadURL, (configMAX_PRIORITIES - 1), NULL, 1);
+    if (taskResult != pdPASS) {
         ESP_LOGE("Download OTA", "Couldn't create download OTA task");
         return request->reply(500);
     }
diff --git a/esp32/lib/ESP32-sveltekit/firmware_download_service.h b/esp32/lib/ESP32-sveltekit/firmware_download_service.h
index 3566791..879fa67 100644
--- a/esp32/lib/ESP32-sveltekit/firmware_download_service.h
+++ b/esp32/lib/ESP32-sveltekit/firmware_download_service.h
@@ -18,7 +18,7 @@ class DownloadFirmwareService {
   public:
     DownloadFirmwareService();
 
-    esp_err_t downloadUpdate(PsychicRequest *request, JsonVariant &json);
+    esp_err_t handleDownloadUpdate(PsychicRequest *request, JsonVariant &json);
 
   private:
 };